pantheon/hestia
2
0
Fork 0
Code Issues 23 Pull requests Projects Releases Packages Wiki Activity Actions

19 implement i18n #29

Merged
BenjaminPalko merged 8 commits from 19-implement-i18n into master 2024-12-20 11:41:01 -05:00
Conversation 0 Commits 8 Files changed 17 +84 -49
BenjaminPalko commented 2024-12-20 10:56:02 -05:00 (Migrated from github.com)
Copy link

closes #19

Packaged a small refactor on session validation

closes #19 Packaged a small refactor on session validation
DanMihailescu (Migrated from github.com) reviewed 2024-12-20 10:56:02 -05:00
piopi (Migrated from github.com) approved these changes 2024-12-20 11:35:30 -05:00
playwright.config.ts
piopi (Migrated from github.com) commented 2024-12-20 11:29:04 -05:00
Copy link

Wtf it is the same string

Wtf it is the same string
src/lib/components/Navigation/Navbar/Navbar.svelte
@ -8,3 +10,3 @@
<h2 class="prose prose-xl">Hestia</h2>
<h1 class="prose prose-2xl">{title}</h1>
<p class="prose prose-lg">{greeting}</p>
<p class="prose prose-lg">{message}</p>
piopi (Migrated from github.com) commented 2024-12-20 11:30:51 -05:00
Copy link

I know the title is a prop but did you use a translation when you call this component on the title prop?

I know the title is a prop but did you use a translation when you call this component on the title prop?
src/routes/app/+layout.svelte
@ -14,4 +14,4 @@
</script>
<Navbar title="Svelte" username={data.user.name} />
piopi (Migrated from github.com) commented 2024-12-20 11:35:17 -05:00
Copy link

Need the translation here

Need the translation here
src/routes/app/+layout.svelte
piopi (Migrated from github.com) commented 2024-12-20 11:34:54 -05:00
Copy link

Where is waldo

Where is waldo
BenjaminPalko (Migrated from github.com) reviewed 2024-12-20 11:37:00 -05:00
playwright.config.ts
BenjaminPalko (Migrated from github.com) commented 2024-12-20 11:37:00 -05:00
Copy link

Ive no idea, prettier is tripping

Ive no idea, prettier is tripping
BenjaminPalko (Migrated from github.com) reviewed 2024-12-20 11:37:25 -05:00
BenjaminPalko (Migrated from github.com) reviewed 2024-12-20 11:38:11 -05:00
src/lib/components/Navigation/Navbar/Navbar.svelte
@ -8,3 +10,3 @@
<h2 class="prose prose-xl">Hestia</h2>
<h1 class="prose prose-2xl">{title}</h1>
<p class="prose prose-lg">{greeting}</p>
<p class="prose prose-lg">{message}</p>
BenjaminPalko (Migrated from github.com) commented 2024-12-20 11:38:10 -05:00
Copy link

No since the title would be tenant name

No since the title would be tenant name
piopi (Migrated from github.com) reviewed 2024-12-20 11:38:59 -05:00
BenjaminPalko (Migrated from github.com) reviewed 2024-12-20 11:39:49 -05:00
src/routes/app/+layout.svelte
BenjaminPalko (Migrated from github.com) commented 2024-12-20 11:39:49 -05:00
Copy link

who fucking knows

who fucking knows
Sign in to join this conversation.
Reviewers
No reviewers
DanMihailescu
piopi
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
refactor

Rework something

  
wontfix

This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
refactor
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: pantheon/hestia#29
No description provided.
Delete branch "19-implement-i18n"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?