Build out components #45
No reviewers
Labels
No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
refactor
wontfix
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: pantheon/hestia#45
Loading…
Add table
Reference in a new issue
No description provided.
Delete branch "build-out-components"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
I made some of the simpler Daisy components, we can leave the more complex ones for later
@ -1,61 +1,68 @@<script lang="ts">import type { DaisyColor, DaisySize } from '$lib/types';Any reason or standard you had to change the onClick to onclick?
@ -1,61 +1,68 @@<script lang="ts">import type { DaisyColor, DaisySize } from '$lib/types';Yeah, onclick is the default prop name on elements in svelte, its not the same as with React where it follows JS camel case styling.
@ -0,0 +18,4 @@'success','warning','error',],I see some of them also used in the alert and other place, maybe it could be worth it to put them in an array or enums as UI tokens
Same thing for the sizes tokens and anything you see used in common
Just noticed my comment is on the stories file but I meant it to be on the component itself
@ -1,61 +1,68 @@<script lang="ts">import type { DaisyColor, DaisySize } from '$lib/types';kk thanks, good to know
@ -1,61 +1,68 @@<script lang="ts">import type { DaisyColor, DaisySize } from '$lib/types';actually, I think I'm gonig to redo the typing here, there is redundancy
@ -0,0 +18,4 @@'success','warning','error',],It did occur to me, there can be variation between components though, some will have ghost, others might have neutral, or not. So I just haven't made a decision for it yet.