pantheon/hestia
2
0
Fork 0
Code Issues 23 Pull requests Projects Releases Packages Wiki Activity Actions

41 create tenant twilio config #62

Merged
BenjaminPalko merged 20 commits from 41-create-tenant-twilio-config into master 2025-01-26 23:36:06 -05:00
Conversation 1 Commits 20 Files changed 24 +515 -57
BenjaminPalko commented 2025-01-17 11:46:09 -05:00 (Migrated from github.com)
Copy link
No description provided.
DanMihailescu (Migrated from github.com) reviewed 2025-01-17 11:46:09 -05:00
piopi (Migrated from github.com) reviewed 2025-01-17 11:52:58 -05:00
prisma/schema.prisma
@ -42,0 +51,4 @@
tenantId String @unique
twilioConfig TwilioConfig?
piopi (Migrated from github.com) commented 2025-01-17 11:52:58 -05:00
Copy link

Not a fan of calling this TenantConfig while it contains twillio specific fields, if you have a new integration like sendgrid, will you just add a new column here? It doesn't feel scalable, I think you could either rename this to TwillioTenantConfig, if you don't wanna deal with it now or have a generic way to store integration credentials. Like have two column, integrationName, integrationValues (JSON column)

Not a fan of calling this TenantConfig while it contains twillio specific fields, if you have a new integration like sendgrid, will you just add a new column here? It doesn't feel scalable, I think you could either rename this to TwillioTenantConfig, if you don't wanna deal with it now or have a generic way to store integration credentials. Like have two column, integrationName, integrationValues (JSON column)
piopi (Migrated from github.com) reviewed 2025-01-17 11:53:52 -05:00
prisma/schema.prisma
@ -42,0 +51,4 @@
tenantId String @unique
twilioConfig TwilioConfig?
piopi (Migrated from github.com) commented 2025-01-17 11:53:52 -05:00
Copy link

and use Zod for validation

and use Zod for validation
netlify[bot] commented 2025-01-26 10:51:34 -05:00 (Migrated from github.com)
Copy link

Deploy Preview for hestia-home ready!

Name Link
Latest commit 754f9b57ea
Latest deploy log https://app.netlify.com/sites/hestia-home/deploys/67970ce672b038000824b0b4
Deploy Preview https://deploy-preview-62--hestia-home.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

### <span aria-hidden="true">✅</span> Deploy Preview for *hestia-home* ready! | Name | Link | |:-:|------------------------| |<span aria-hidden="true">🔨</span> Latest commit | 754f9b57ea74a3755abeada09253c31593b7cf02 | |<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/sites/hestia-home/deploys/67970ce672b038000824b0b4 | |<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-62--hestia-home.netlify.app](https://deploy-preview-62--hestia-home.netlify.app) | |<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br />![QR Code](https://app.netlify.com/qr-code/eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1cmwiOiJodHRwczovL2RlcGxveS1wcmV2aWV3LTYyLS1oZXN0aWEtaG9tZS5uZXRsaWZ5LmFwcCJ9.77_RdHv02aj_E5JyCA5Pr8h3x_DoFxBLtyNQ00XhL4o)<br /><br />_Use your smartphone camera to open QR code link._</details> | --- <!-- [hestia-home Preview](https://deploy-preview-62--hestia-home.netlify.app) --> _To edit notification comments on pull requests, go to your [Netlify site configuration](https://app.netlify.com/sites/hestia-home/configuration/notifications#deploy-webhooks)._
piopi (Migrated from github.com) approved these changes 2025-01-26 14:23:46 -05:00
Sign in to join this conversation.
Reviewers
No reviewers
DanMihailescu
piopi
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
refactor

Rework something

  
wontfix

This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
refactor
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: pantheon/hestia#62
No description provided.
Delete branch "41-create-tenant-twilio-config"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?