pantheon/hestia
2
0
Fork 0
Code Issues 23 Pull requests Projects Releases Packages Wiki Activity Actions

chore: no magic strings #34

Merged
BenjaminPalko merged 2 commits from paraglider-no-magic-strings into master 2024-12-30 17:29:47 -05:00
Conversation 4 Commits 2 Files changed 4 +50 -24
BenjaminPalko commented 2024-12-24 15:02:13 -05:00 (Migrated from github.com)
Copy link
No description provided.
DanMihailescu (Migrated from github.com) reviewed 2024-12-24 15:02:13 -05:00
piopi (Migrated from github.com) reviewed 2024-12-24 15:57:52 -05:00
piopi (Migrated from github.com) left a comment
Copy link

Don't think you should use translation for API errors

Don't think you should use translation for API errors
BenjaminPalko commented 2024-12-27 17:33:33 -05:00 (Migrated from github.com)
Copy link

Don't think you should use translation for API errors

They are form errors, we could return a flag from the server then serve the message on the client. Its an extra step, but does that make sense?

> Don't think you should use translation for API errors They are form errors, we could return a flag from the server then serve the message on the client. Its an extra step, but does that make sense?
piopi commented 2024-12-28 10:07:41 -05:00 (Migrated from github.com)
Copy link

Don't think you should use translation for API errors

They are form errors, we could return a flag from the server then serve the message on the client. Its an extra step, but does that make sense?

It makes sense, I like that way!

> > Don't think you should use translation for API errors > > They are form errors, we could return a flag from the server then serve the message on the client. Its an extra step, but does that make sense? It makes sense, I like that way!
BenjaminPalko commented 2024-12-30 12:37:28 -05:00 (Migrated from github.com)
Copy link

Don't think you should use translation for API errors

They are form errors, we could return a flag from the server then serve the message on the client. Its an extra step, but does that make sense?

It makes sense, I like that way!

Opened #35 for this work, its a bit more involved than what Im doing here since we need a system for passing errors from the backend to the frontend + form needs to properly handle error states

> > > Don't think you should use translation for API errors > > > > > > They are form errors, we could return a flag from the server then serve the message on the client. Its an extra step, but does that make sense? > > It makes sense, I like that way! Opened #35 for this work, its a bit more involved than what Im doing here since we need a system for passing errors from the backend to the frontend + form needs to properly handle error states
👍 1
piopi commented 2024-12-30 12:43:35 -05:00 (Migrated from github.com)
Copy link

@BenjaminPalko Can you remove please the translation from the api 🙏🏽

@BenjaminPalko Can you remove please the translation from the api 🙏🏽
piopi (Migrated from github.com) approved these changes 2024-12-30 15:10:00 -05:00
Sign in to join this conversation.
Reviewers
No reviewers
DanMihailescu
piopi
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
refactor

Rework something

  
wontfix

This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
refactor
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: pantheon/hestia#34
No description provided.
Delete branch "paraglider-no-magic-strings"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?