pantheon/hestia
2
0
Fork 0
Code Issues 23 Pull requests Projects Releases Packages Wiki Activity Actions

Bug: use clsx on svelte element classNames #60

Merged
BenjaminPalko merged 1 commit from bug-svelte-check-failing-on-className into master 2025-01-16 22:11:38 -05:00
Conversation 0 Commits 1 Files changed 9 +17 -14
BenjaminPalko commented 2025-01-16 22:06:39 -05:00 (Migrated from github.com)
Copy link

There was a type mismatch between the className on svelte elements and the input type of twMerge, svelte uses clsx input types as valid values for classNames (array, object). See clsx #Usage

There was a type mismatch between the className on svelte elements and the input type of twMerge, svelte uses clsx input types as valid values for classNames (array, object). [See clsx #Usage](https://github.com/lukeed/clsx?tab=readme-ov-file#usage)
piopi (Migrated from github.com) reviewed 2025-01-16 22:06:39 -05:00
DanMihailescu (Migrated from github.com) approved these changes 2025-01-16 22:11:30 -05:00
Sign in to join this conversation.
Reviewers
No reviewers
piopi
DanMihailescu
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
refactor

Rework something

  
wontfix

This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
refactor
wontfix
Milestone
Clear milestone
No items
No milestone
POC
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: pantheon/hestia#60
No description provided.
Delete branch "bug-svelte-check-failing-on-className"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?