Lucia Authentication #8

2024-12-17T12:06:01-05:00

DanMihailescu commented

2024-12-17 12:06:01 -05:00

(Migrated from github.com)

There you go

BenjaminPalko (Migrated from github.com) reviewed 2024-12-17 14:09:51 -05:00

prisma/schema.prisma

BenjaminPalko (Migrated from github.com) commented

2024-12-17 14:09:51 -05:00

@default(now()) on updateAt or it will be null

BenjaminPalko (Migrated from github.com) reviewed 2024-12-17 14:10:51 -05:00

prisma/schema.prisma

					
				@ -26,0 +34,4 @@

				  userId       String

				  user         User     @relation(references: [id], fields: [userId])

				}

BenjaminPalko (Migrated from github.com) commented

2024-12-17 14:10:51 -05:00

NIT: references and fields is backwards from how post shows it, can we keep them consistent

BenjaminPalko (Migrated from github.com) reviewed 2024-12-17 14:11:26 -05:00

src/lib/server/lucia.ts

BenjaminPalko (Migrated from github.com) commented

2024-12-17 14:11:26 -05:00

Reuse the $lib/server/prisma client plz

Reuse the `$lib/server/prisma` client plz

BenjaminPalko (Migrated from github.com) reviewed 2024-12-17 14:14:38 -05:00

src/routes/+page.server.ts

BenjaminPalko (Migrated from github.com) commented

2024-12-17 14:14:38 -05:00

I dont think you can type event as a a Session, from the app typedefs you made it should be event.locals.[session or user idk]

I dont think you can type event as a a Session, from the app typedefs you made it should be _event.locals.[session or user idk]_

BenjaminPalko (Migrated from github.com) reviewed 2024-12-17 14:14:57 -05:00

src/routes/+page.server.ts

BenjaminPalko (Migrated from github.com) commented

2024-12-17 14:14:57 -05:00

https://github.com/Machinata/hestia/pull/8/files#diff-b07092d78bfaa239d6ad0d01b0897c3ef49533b08512622d83c6f4e1dd3b363e

BenjaminPalko (Migrated from github.com) reviewed 2024-12-17 14:16:28 -05:00

src/routes/login/+page.server.ts

BenjaminPalko (Migrated from github.com) commented

2024-12-17 14:16:27 -05:00

rename to password ty

rename to `password` ty

BenjaminPalko (Migrated from github.com) reviewed 2024-12-17 14:18:12 -05:00

src/routes/login/+page.server.ts

BenjaminPalko (Migrated from github.com) commented

2024-12-17 14:18:12 -05:00

load the password into a const first like you did with login and please dont force types with as

load the password into a `const` first like you did with login and please dont force types with `as`

DanMihailescu (Migrated from github.com) reviewed 2024-12-18 10:07:51 -05:00

src/routes/+page.server.ts

DanMihailescu (Migrated from github.com) commented

2024-12-18 10:07:50 -05:00

switched back to any type

DanMihailescu (Migrated from github.com) reviewed 2024-12-18 10:11:06 -05:00

src/routes/login/+page.server.ts

DanMihailescu (Migrated from github.com) commented

2024-12-18 10:11:06 -05:00

Did for mem/storage space; added new const to conform

BenjaminPalko (Migrated from github.com) reviewed 2024-12-18 12:33:08 -05:00

src/lib/server/lucia.ts

BenjaminPalko (Migrated from github.com) commented

2024-12-18 12:33:08 -05:00

You dont need to set it to a const...

BenjaminPalko (Migrated from github.com) reviewed 2024-12-18 12:34:07 -05:00

src/routes/+page.server.ts

BenjaminPalko (Migrated from github.com) commented

2024-12-18 12:34:07 -05:00

Use the logger pls

BenjaminPalko (Migrated from github.com) approved these changes 2024-12-18 14:52:00 -05:00

Sign in to join this conversation.

No reviewers

BenjaminPalko

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: pantheon/hestia#8

Rows
Columns