Lucia Authentication #8

Merged
DanMihailescu merged 18 commits from undoPretty into master 2024-12-19 20:06:45 -05:00
Showing only changes of commit 39c96ac88a - Show all commits

View file

@ -1,7 +1,7 @@
BenjaminPalko commented 2024-12-17 14:14:38 -05:00 (Migrated from github.com)
Review

I dont think you can type event as a a Session, from the app typedefs you made it should be event.locals.[session or user idk]

I dont think you can type event as a a Session, from the app typedefs you made it should be _event.locals.[session or user idk]_
BenjaminPalko commented 2024-12-17 14:14:57 -05:00 (Migrated from github.com)
Review
https://github.com/Machinata/hestia/pull/8/files#diff-b07092d78bfaa239d6ad0d01b0897c3ef49533b08512622d83c6f4e1dd3b363e
DanMihailescu commented 2024-12-18 10:07:50 -05:00 (Migrated from github.com)
Review

switched back to any type

switched back to any type
BenjaminPalko commented 2024-12-18 12:34:07 -05:00 (Migrated from github.com)
Review

Use the logger pls

Use the logger pls
BenjaminPalko commented 2024-12-17 14:14:38 -05:00 (Migrated from github.com)
Review

I dont think you can type event as a a Session, from the app typedefs you made it should be event.locals.[session or user idk]

I dont think you can type event as a a Session, from the app typedefs you made it should be _event.locals.[session or user idk]_
BenjaminPalko commented 2024-12-17 14:14:57 -05:00 (Migrated from github.com)
Review
https://github.com/Machinata/hestia/pull/8/files#diff-b07092d78bfaa239d6ad0d01b0897c3ef49533b08512622d83c6f4e1dd3b363e
DanMihailescu commented 2024-12-18 10:07:50 -05:00 (Migrated from github.com)
Review

switched back to any type

switched back to any type
BenjaminPalko commented 2024-12-18 12:34:07 -05:00 (Migrated from github.com)
Review

Use the logger pls

Use the logger pls
import { prisma } from '$lib/server/prisma';
export async function load(event) {
console.log(event.userId);
BenjaminPalko commented 2024-12-17 14:14:38 -05:00 (Migrated from github.com)
Review

I dont think you can type event as a a Session, from the app typedefs you made it should be event.locals.[session or user idk]

I dont think you can type event as a a Session, from the app typedefs you made it should be _event.locals.[session or user idk]_
BenjaminPalko commented 2024-12-17 14:14:57 -05:00 (Migrated from github.com)
Review
https://github.com/Machinata/hestia/pull/8/files#diff-b07092d78bfaa239d6ad0d01b0897c3ef49533b08512622d83c6f4e1dd3b363e
DanMihailescu commented 2024-12-18 10:07:50 -05:00 (Migrated from github.com)
Review

switched back to any type

switched back to any type
BenjaminPalko commented 2024-12-18 12:34:07 -05:00 (Migrated from github.com)
Review

Use the logger pls

Use the logger pls
const userId = event.userId;
BenjaminPalko commented 2024-12-17 14:14:38 -05:00 (Migrated from github.com)
Review

I dont think you can type event as a a Session, from the app typedefs you made it should be event.locals.[session or user idk]

I dont think you can type event as a a Session, from the app typedefs you made it should be _event.locals.[session or user idk]_
BenjaminPalko commented 2024-12-17 14:14:57 -05:00 (Migrated from github.com)
Review
https://github.com/Machinata/hestia/pull/8/files#diff-b07092d78bfaa239d6ad0d01b0897c3ef49533b08512622d83c6f4e1dd3b363e
DanMihailescu commented 2024-12-18 10:07:50 -05:00 (Migrated from github.com)
Review

switched back to any type

switched back to any type
BenjaminPalko commented 2024-12-18 12:34:07 -05:00 (Migrated from github.com)
Review

Use the logger pls

Use the logger pls
console.log(event.cookies.get('user'));
BenjaminPalko commented 2024-12-17 14:14:38 -05:00 (Migrated from github.com)
Review

I dont think you can type event as a a Session, from the app typedefs you made it should be event.locals.[session or user idk]

I dont think you can type event as a a Session, from the app typedefs you made it should be _event.locals.[session or user idk]_
BenjaminPalko commented 2024-12-17 14:14:57 -05:00 (Migrated from github.com)
Review
https://github.com/Machinata/hestia/pull/8/files#diff-b07092d78bfaa239d6ad0d01b0897c3ef49533b08512622d83c6f4e1dd3b363e
DanMihailescu commented 2024-12-18 10:07:50 -05:00 (Migrated from github.com)
Review

switched back to any type

switched back to any type
BenjaminPalko commented 2024-12-18 12:34:07 -05:00 (Migrated from github.com)
Review

Use the logger pls

Use the logger pls
const userId = event.cookies.get('user');
BenjaminPalko commented 2024-12-17 14:14:38 -05:00 (Migrated from github.com)
Review

I dont think you can type event as a a Session, from the app typedefs you made it should be event.locals.[session or user idk]

I dont think you can type event as a a Session, from the app typedefs you made it should be _event.locals.[session or user idk]_
BenjaminPalko commented 2024-12-17 14:14:57 -05:00 (Migrated from github.com)
Review
https://github.com/Machinata/hestia/pull/8/files#diff-b07092d78bfaa239d6ad0d01b0897c3ef49533b08512622d83c6f4e1dd3b363e
DanMihailescu commented 2024-12-18 10:07:50 -05:00 (Migrated from github.com)
Review

switched back to any type

switched back to any type
BenjaminPalko commented 2024-12-18 12:34:07 -05:00 (Migrated from github.com)
Review

Use the logger pls

Use the logger pls
if (!userId) {
return {
authenticated: false

BenjaminPalko commented 2024-12-17 14:14:38 -05:00 (Migrated from github.com)
Review

I dont think you can type event as a a Session, from the app typedefs you made it should be event.locals.[session or user idk]

I dont think you can type event as a a Session, from the app typedefs you made it should be _event.locals.[session or user idk]_
BenjaminPalko commented 2024-12-17 14:14:57 -05:00 (Migrated from github.com)
Review
https://github.com/Machinata/hestia/pull/8/files#diff-b07092d78bfaa239d6ad0d01b0897c3ef49533b08512622d83c6f4e1dd3b363e
DanMihailescu commented 2024-12-18 10:07:50 -05:00 (Migrated from github.com)
Review

switched back to any type

switched back to any type
BenjaminPalko commented 2024-12-18 12:34:07 -05:00 (Migrated from github.com)
Review

Use the logger pls

Use the logger pls
BenjaminPalko commented 2024-12-17 14:14:38 -05:00 (Migrated from github.com)
Review

I dont think you can type event as a a Session, from the app typedefs you made it should be event.locals.[session or user idk]

I dont think you can type event as a a Session, from the app typedefs you made it should be _event.locals.[session or user idk]_
BenjaminPalko commented 2024-12-17 14:14:57 -05:00 (Migrated from github.com)
Review
https://github.com/Machinata/hestia/pull/8/files#diff-b07092d78bfaa239d6ad0d01b0897c3ef49533b08512622d83c6f4e1dd3b363e
DanMihailescu commented 2024-12-18 10:07:50 -05:00 (Migrated from github.com)
Review

switched back to any type

switched back to any type
BenjaminPalko commented 2024-12-18 12:34:07 -05:00 (Migrated from github.com)
Review

Use the logger pls

Use the logger pls