73 batch sms messaging #85
No reviewers
Labels
No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
refactor
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: pantheon/hestia#85
Loading…
Add table
Reference in a new issue
No description provided.
Delete branch "73-batch-sms-messaging"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
✅ Deploy Preview for hestia-home ready!
1a41da24edToggle QR Code...
Use your smartphone camera to open QR code link.
To edit notification comments on pull requests, go to your Netlify site configuration.
@ -0,0 +41,4 @@}}/></th><th> Name </th>"Unit #: First Name" or just "Unit #" would work better for more user privacy (admin of condo shouldnt have access to personal data).
@ -26,0 +30,4 @@...(configs.twilioConfig && {twilioConfig: decryptTwilioConfig(configs.twilioConfig),}),},Should return something; maybe an error page redirect
@ -32,2 +35,4 @@}const residents = await prisma.resident.findMany({where: {Why are all of these the same?
@ -58,2 +67,4 @@return fail(400, { error: 'invalid_recipients' });}logger.info(recipients);Should give user popup saying they need to select recipients; not redirect to error page
@ -26,0 +30,4 @@...(configs.twilioConfig && {twilioConfig: decryptTwilioConfig(configs.twilioConfig),}),},Nah, the page handles this. If the config is missing it displays a message
@ -32,2 +35,4 @@}const residents = await prisma.resident.findMany({where: {what do you mean?
@ -58,2 +67,4 @@return fail(400, { error: 'invalid_recipients' });}logger.info(recipients);This is the server-side file, it doesn't control the web page. It is also just the form post response which doesn't change the page location
@ -0,0 +41,4 @@}}/></th><th> Name </th>Its fine that they can see their names, its not a privacy concern. We also dont have tables for units/residences
@ -32,2 +35,4 @@}const residents = await prisma.resident.findMany({where: {Id = zod.string
Token = Zod.string
Phonenumber = zod.string
From that I can see there's no parsing each item
@ -32,2 +35,4 @@}const residents = await prisma.resident.findMany({where: {its a zod schema for validating the twilio config
@ -58,2 +67,4 @@return fail(400, { error: 'invalid_recipients' });}logger.info(recipients);Can you put all the errors in an enum and throwing 400 is too generic
This could go in an util